Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Haskell colors against haskell-vim. #87

Merged
merged 1 commit into from
May 28, 2019

Conversation

rbong
Copy link

@rbong rbong commented May 28, 2019

Relates to morhetz#190.

🤖 This pull request has been automatically copied from morhetz#209 🤖

@rbong rbong added the migrated Issues migrated from morhetz/gruvbox label May 28, 2019
@rbong
Copy link
Author

rbong commented May 28, 2019

The original PR has a lot of positive attention and the original issue seems important. I'm going to merge this in.

@rbong rbong merged commit cc0e25d into gruvbox-community:master May 28, 2019
@mlopes
Copy link

mlopes commented Jul 30, 2019

@rbong did this fix it for you? I'm still seeing it with some odd colour. Here's a screenshot of how it looks in Haskell for me vs how it looks for example when looking at the source of gruvbox:

image

image

@goolord
Copy link

goolord commented Jan 16, 2021

yeah this looks pretty hideous with haskell-nvim, i don't know that many people who regularly write haskell who uses the default ftplugin

@rbong
Copy link
Author

rbong commented Jan 16, 2021

If someone wants to define some haskell-nvim highlight groups I will gladly merge it in. I'm not familiar with Haskell constructs so I'm not sure I can effectively solve this myself.

@goolord
Copy link

goolord commented Jan 19, 2021

here's the highlight groups i use daily

haskell vim highlight groups (click to expand)
hi! link haskelltype gruvboxyellow

hi! link haskellidentifier gruvboxgreen

hi! link haskellseparator gruvboxfg3
hi! link haskelldelimiter gruvboxfg3
hi! link haskelloperators gruvboxblue
hi! link haskellbacktick haskelloperators

hi! link haskellstatement gruvboxorange

hi! link haskellconditional gruvboxred
hi! link haskellkeyword gruvboxred
hi! link haskelllet gruvboxred
hi! link haskellwhere gruvboxred

hi! link haskelldefault gruvboxaqua
hi! link haskellbottom gruvboxaqua
hi! link haskellblockkeywords gruvboxaqua
hi! link haskellimportkeywords gruvboxaqua
hi! link haskelldeclkeyword gruvboxaqua
hi! link haskelldecl gruvboxaqua
hi! link haskellderiving gruvboxaqua
hi! link haskellassoctype gruvboxaqua

hi! link haskellnumber gruvboxpurple
hi! link haskellpragma gruvboxpurple

hi! link haskellstring gruvboxgreen
hi! link haskellchar gruvboxgreen

image

unfortunately, this looks nice with haskell-vim, but not great for the ftplugin that ships with vim. idk if there is precedence for supporting conflicting ftplugins like this, or if this would be better suited to being fixed upstream haskell-vim

@suleymanboyar
Copy link

@goolord how did you apply the changes? Sourcing vim and doing PlugUpdate doesn't seem to work.

@goolord
Copy link

goolord commented May 21, 2021

@OnionHat I forked gruvbox, I think. I just use the default haskell ft plugin now.

@suleymanboyar
Copy link

@goolord thanks for the answer! Forking it and editing the part did not seem to work, oh well, but thanks again!

@goolord
Copy link

goolord commented May 22, 2021

@OnionHat ah it looks like there are new highlight groups for the colors. (GruvboxYellow instead of gruvboxyellow etc?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migrated Issues migrated from morhetz/gruvbox
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants