-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the Haskell colors against haskell-vim. #87
Conversation
The original PR has a lot of positive attention and the original issue seems important. I'm going to merge this in. |
@rbong did this fix it for you? I'm still seeing it with some odd colour. Here's a screenshot of how it looks in Haskell for me vs how it looks for example when looking at the source of gruvbox: |
yeah this looks pretty hideous with haskell-nvim, i don't know that many people who regularly write haskell who uses the default ftplugin |
If someone wants to define some haskell-nvim highlight groups I will gladly merge it in. I'm not familiar with Haskell constructs so I'm not sure I can effectively solve this myself. |
here's the highlight groups i use daily haskell vim highlight groups (click to expand)hi! link haskelltype gruvboxyellow
hi! link haskellidentifier gruvboxgreen
hi! link haskellseparator gruvboxfg3
hi! link haskelldelimiter gruvboxfg3
hi! link haskelloperators gruvboxblue
hi! link haskellbacktick haskelloperators
hi! link haskellstatement gruvboxorange
hi! link haskellconditional gruvboxred
hi! link haskellkeyword gruvboxred
hi! link haskelllet gruvboxred
hi! link haskellwhere gruvboxred
hi! link haskelldefault gruvboxaqua
hi! link haskellbottom gruvboxaqua
hi! link haskellblockkeywords gruvboxaqua
hi! link haskellimportkeywords gruvboxaqua
hi! link haskelldeclkeyword gruvboxaqua
hi! link haskelldecl gruvboxaqua
hi! link haskellderiving gruvboxaqua
hi! link haskellassoctype gruvboxaqua
hi! link haskellnumber gruvboxpurple
hi! link haskellpragma gruvboxpurple
hi! link haskellstring gruvboxgreen
hi! link haskellchar gruvboxgreen unfortunately, this looks nice with haskell-vim, but not great for the ftplugin that ships with vim. idk if there is precedence for supporting conflicting ftplugins like this, or if this would be better suited to being fixed upstream haskell-vim |
@goolord how did you apply the changes? Sourcing vim and doing PlugUpdate doesn't seem to work. |
@OnionHat I forked gruvbox, I think. I just use the default haskell ft plugin now. |
@goolord thanks for the answer! Forking it and editing the part did not seem to work, oh well, but thanks again! |
@OnionHat ah it looks like there are new highlight groups for the colors. ( |
Relates to morhetz#190.
🤖 This pull request has been automatically copied from morhetz#209 🤖