Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markor 2.10.2 can't write/edit SD Card files #1799

Closed
3 tasks done
chromer030 opened this issue Aug 17, 2022 · 7 comments · Fixed by #1521
Closed
3 tasks done

Markor 2.10.2 can't write/edit SD Card files #1799

chromer030 opened this issue Aug 17, 2022 · 7 comments · Fixed by #1521
Assignees
Labels
Milestone

Comments

@chromer030
Copy link

chromer030 commented Aug 17, 2022

⚠️ This issue respects the following points: ⚠️

  • This is a bug. Not a question or feature request.
  • The issue is not already reported at Issues or discussions. (I've searched it).
  • Markor is up to date. See Releases for the latest version. Updates are available from F-Droid and GitHub.

Description

Markor 2.10.2 can't edit files on sdcard while permission is granted.
Save button doesn't work and all the changes will be discard by closing the app or leaving the note.
Version 2.10.1 was OK.

Markor can write and edit files in SD Card Appdata but not on specified folder in SD Card.
(I cleared the data and cache , uninstall the app and reinstall it but the issue persists.)

Steps to reproduce

  1. Specify a folder on SD Card for notebook
  2. Try to edit a file.
  3. Save button doesn't work.

Information

Android version: 7.1.2 arm64
Device: Lenovo
App Version: 2.10.2

Source

GitHub Releases

Format / File type

Markdown

Additional info / Log

Tested on another device with following specification and whole the procedure :
Device : Asus Zenfone
Android : 10 arm64 lineage
Markor : 2.10.2
SD Card filesystem : fat32 , formatted by android

Procedure :
Installing Markor > Settings > General > Notebook > Selecting F941-7CDA which is root of SD Card and granting permission > navigating to a folder for example Download > Select this folder > Now the + button for adding file doesn't work > creating a text file with OS file manager > Open markor again > opening file > writing something > save button doesn't work !

Screenshot_20220714-010027727

tested version 2.10.1 with this device and both + and save buttons working.

@gsantner
Copy link
Owner

gsantner commented Aug 17, 2022

....I extra asked before the update if sdcard work, and I got as response (#603) by multiple users that it works. And it works on my device very well too 🤷.

Do you have any newer device by hand (i.e. Android>=10)?

Now we have it there and somebody needs to fix it it looks like....
Just saying, SD Card is a frequently asked topic, but in the many years of Markor never somebody contributed something for SD Card support. Help is totally welcome. Android storage & SD cards is a every-year-changing topic that is very hard to make work across all Android versions.

Related: #1359 #1521 #603

@chromer030
Copy link
Author

Using a folder in Internal Storage is OK on both android 7.1.2 and 10.
Both + and Saving buttons working.
(/storage/emulated/0)

@gsantner gsantner self-assigned this Aug 17, 2022
@gsantner gsantner added this to the Markor v2.11 milestone Aug 17, 2022
@gsantner
Copy link
Owner

gsantner commented Aug 17, 2022

@chromer030
You will find a android-apk download button here. Can you please try that test app if it works for you & sdcard?

https://github.com/gsantner/markor/actions/runs/2875725644

Repository owner deleted a comment from chromer030 Aug 17, 2022
@chromer030
Copy link
Author

Tested the Mordor app and confirm that latest commit fixed the issue.
Tested on both 7.1.2 and 10.

@gsantner
Copy link
Owner

Thanks, good to hear and thanks for reporting.

@chromer030
Copy link
Author

Thank you for fixing it fast.

@gsantner
Copy link
Owner

Usually it's not that easy. This one was some check not triggering with SAF 😄 .

@gsantner gsantner added the bug label Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants