Upgrade architecture - Android SDK33, AndroidX & MANAGE_EXTERNAL_STORAGE, closes #1359

[gsantner]

Preparation of update to latest Android SDK, support libraries, file access & more

[gsantner]

I uploaded a test version to google play and requested the "sensitive" MANAGE_EXTERNAL_STORAGE permission for direct file access.

Uploaded "128 (v2.8.4)" from this branch to public testing. let's see what google says and if they agree and publish it.

• https://play.google.com/store/apps/details?id=net.gsantner.markor
• https://play.google.com/apps/testing/net.gsantner.markor

At time of this comment it says this - which means it's not published (yet/denied)

[gsantner]

Google disagrees that a document & file manager should have direct file access.

At least having one of the written use cases should make the app Eligible to use this access type.
Markor is at least one of these to my opinion:

• Document management apps
• File management
• Search (On Device)

Google says Markor is not eligable for it though. I asked for another review, but not looks like they change their mind.

[gsantner]

Google denied my appeal request (wow !!appeal!! as like it would be a crime to read files).

Thus, I won't waste my time on this project with keeping Google happy anymore - main distribution channel is and continues to be F-Droid. (=No updates for Markor on Google Play anymore)

Markor also stays on Android SDK v29 till there is a real urgent need.

[gsantner]

@harshad1 @fredericjacob For your information

[harshad1]

Thus, I won't waste my time on this project with keeping Google happy anymore - main distribution channel is and continues to be F-Droid. (=No updates for Markor on Google Play anymore)

Would it be worth it to create a google play version where the notebook is restricted to Markor's app-specific storage?

[gsantner]

I don't really want to make a separate version for gplay, with separate type of issues, separate type of questions and people suddenly not being able to edit their existing files anymore.

[harshad1]

Fair enough. Maybe Google will listen if enough people complain :) Jan. 6, 2022 10:53:00 Gregor Santner ***@***.***>:

…

I don't really want to make a separate version for gplay, with separate type of issues, separate type of questions and people suddenly not being able to edit their existing files anymore. — Reply to this email directly, view it on GitHub[#1521 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AAOZ3TFTTPZWKTVRTXPF7C3UUXQIVANCNFSM5JK56HTA]. Triage notifications on the go with GitHub Mobile for iOS[https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675] or Android[https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub]. You are receiving this because you were mentioned. [data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAFQAAABUCAYAAAAcaxDBAAAAAXNSR0IArs4c6QAAAARzQklUCAgICHwIZIgAAAAySURBVHic7cEBDQAAAMKg909tDjegAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAeDVulAABbzDScQAAAABJRU5ErkJggg==###24x24:true###][Tracking image][https://github.com/notifications/beacon/AAOZ3TFYHYSJPJVWPOKCG5LUUXQIVA5CNFSM5JK56HTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOHQBRFKA.gif]

[fredericjacob]

That's a really weird decision and argumentation for the rejection... Does Google tell apps with integrated cloud service access like Google Drive, Dropbox, etc. to consider "more privacy-friendly options", too? I think as well that Markor matches both the file manager and document manager criteria and thus should be compliant with the policy. Actually direct file access IS required to use Markor in synergy with other apps that access the same data, like synchronization via Syncthing etc.

However, I wouldn't give up on Google Play completely. I think the app could lose a big (especially non-techie) audience otherwise, which would be a shame because Markor is really outstanding in its field in terms of features and development, plus being FOSS... Maybe there's still a way to fight the rejection? Continue to argue why it IS compliant? Or like @harshad1 proposed, deploy a variant to Google Play, but maybe display a hint in the description that full file access is not possible in the Google Play version because of how Google interprets its own policy?

[fredericjacob]

Maybe Google will listen if enough people complain :)

That's another hope I have. I think there were other popular apps that were banned from Google Play in a first place because of some "policy violation", but could celebrate a comeback after some heavy shitstorms on the internet. ;)

[gsantner]

apps that were banned from Google Play

noting: Markor is not banned at gplay, available as is in v2.8. Just can't deploy new updates without removing Markor's reason of existance.

[harshad1]

FYI, after installing this I had to go into app info and give it full file permissions again.

I installed a release build with my local key

[gsantner]

Yes, API30+ not uses the Marshmallow storage one but the ManageExternalStorage in this PR

[gsantner]

Google Play has changed the opinion on the files permission now with the 2.10.1 submission and it passed reviews.
So merging this pull request and thus big, major architecture changes, to be ready for future Android versions and Android features.