Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.12.2 New file Template name corresponds to wrong content #2312

Closed
bertisLongfellow opened this issue May 30, 2024 · 10 comments · Fixed by #2307
Closed

v2.12.2 New file Template name corresponds to wrong content #2312

bertisLongfellow opened this issue May 30, 2024 · 10 comments · Fixed by #2307
Assignees
Labels
Milestone

Comments

@bertisLongfellow
Copy link

IMPORTANT

  • App version: 2.12.2
  • Android version/rom: 14
  • Device: Pixel 7A
  • I accept that this issue will be closed without further notice in case I didn't describe the problem including general information, or didn't search for similar issues & requests.

Explain the Problem

I created a markdown file specifying the presentation-beamer template. Instead, I got this, looks like csv template:

this is a comment in csv file

below is the header

number;text;finishing date

csv can contain markdown formatting

1;Learn to use Markor formatting

use "..." if the column contains reserved chars

2;"Use Delimitter chars like ""; :,";2019-06-24

use "..." if the column is multiline

3;"multi
line";2059-12-24

Steps to Reproduce

  • hit plus button
  • selected markdown
  • selected presentation-beamer template
  • typed filename
  • hit OK

Log

Log
Not applicable 
@gsantner gsantner reopened this May 30, 2024
@gsantner
Copy link
Owner

sure that you have 2.12.2 and not 2.12.1?

@bertisLongfellow
Copy link
Author

Version 2.12.2 (151). Let me try a full uninstall/ reinstall, I will report back!

@harshad1
Copy link
Collaborator

I may have made a mistake when reorganizing the templates. Will investigate.

@bertisLongfellow
Copy link
Author

I reinstalled using the latest (and same) release from GitHub. I confirm the beamer template is incorrect. I tried two others, csv and todo, they looked incorrect as well. Thanks for investigating.

@gsantner
Copy link
Owner

gsantner commented May 31, 2024 via email

@bertisLongfellow
Copy link
Author

All good! I already presented what I built with Markor on the train yesterday, I enjoy and use Markor a lot. All the best from Canada.

@gsantner
Copy link
Owner

Hey cool, I mean ignoring the template writing issue - how do you like this feature?

I implemented this in a personal hackaton weekend and so far I havent heard from other using it. But I was really happy about the outcome and how easy I can make presentations/slides this way :D.
My inspiration was latex beamer and how long it took to get my presentation presentation-ready.

Did you present it to people / export it to PDF or something / present over HDMI/screenshare? Would just like to know how this helps..what people like...what can be easy done with it from other peoples view.

@gsantner gsantner changed the title Beamer template isn't a beamer template v2.12 New file Template name corresponds to wrong content May 31, 2024
@gsantner gsantner added this to the Markor v2.13 milestone May 31, 2024
@gsantner gsantner changed the title v2.12 New file Template name corresponds to wrong content v2.12.2 New file Template name corresponds to wrong content May 31, 2024
@gsantner gsantner added the bug label May 31, 2024
@harshad1
Copy link
Collaborator

Pretty sure I made an off-by-one error here :(

https://github.com/gsantner/markor/blob/master/app/src/main/java/net/gsantner/markor/frontend/NewFileDialog.java#L252

Simple fix. I'll get it in over the weekend. Until then please insert the org mode template

@bertisLongfellow
Copy link
Author

bertisLongfellow commented Jun 1, 2024

@gsantner This time, and I'd say this is often the case when I use that template, I was walking to the train when I realized I'd neglected to prep a deck for a meeting later that morning. I had written a Word document which I could access on OneDrive (for Work), so I opened and copied the content, and said "hey ChatGPT, please reframe this into a presentation suitable for executive in beamer markdown" and pasted the document, and it did a reasonable job, which I copied and pasted into Markor, tweaked a bit, hit view, it looked good. I had another word document with several identical tables of different categories, which I copied into ChatGPT asking it to sum into one table formatted as markdown beamer slide, added that. I spoke some stuff into ChatGPT requesting cleaning into same format output, moved that over. Tada, complete deck. I could have stopped there and exported as you note, but I sent myself the text file, opened it before the meeting in VS Code on my laptop in the office and tweaked and presented from that.

Markor's the Swiss army knife (multi-functional tool) in the flow. ChatGPT I am learning to use to quickly digest my own written and spoken stuff into useful outputs rapidly, and since it can do it with the necessary formatting...

I was a lot lot lot less sweaty and panicked than I might otherwise have been, and it was a clean, professional deck. I do use PowerPoint, too, and in some situations it's basically required, but the power and simplicity of this workflow drove a few things for me this week. I don't know how you feel about ChatGPT, I am guessing your commitment to sharing open source code means your own work has been absorbed by it and similar tools without any consideration to your time, wishes or rights. I am more than happy to support your time; I not only use it, I enjoy it.

@gsantner
Copy link
Owner

gsantner commented Jun 1, 2024

Thanks for your reply! Great to hear that it's so useful to somebody other then me 😃

elyahw pushed a commit to writing-tools/marelias-notepad that referenced this issue Sep 26, 2024
 by @harshad1, fixes gsantner#2312 gsantner#2313)

* Jump to correct heading via id
* No need to track lines
* As link checkbox to top bar
* Simplify heading, checkbox to title, task filter literal
* Unified and cleaned up link formatting
* new file dialog fixes, no folder in select qn / todo
* launch in new activity
* Improvement to launching activities
* Fixed + improved isFileOutOfThisFormat
* Switching from blink to ripple
* Logic to save and restore file browser position
* Can scroll action bar on repeat items
* Handle unknown formats better
* Handle virtual folders better
* Rounded dialogs, fixes for launching files
* Improved show and flash
* Improved keyboard showing
* Improved how we test for compatible files
* Cleaner way to do dialog radius
* Better showing of folders
* Rounded corners for all dialogs, cleaner structure
* Better text file detection
* Cleaner style system
* Matching colour
* Match system bars with UI colors
* Rounded widget corners, hide text actions bar

---------

Co-authored-by: Gregor Santner <gsantner@mailbox.org>
(cherry picked from commit 92744b3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants