-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for restoring scroll position of file lists #2211
Conversation
We already have logic to flash a view and this is used in other places.
See how it is used here: We already have a function to show and blink a file in the folder view. Just need to call it at the appropriate time. I have added an option to show the currently open file in the file explorer in this PR: An option has been added to the file menu to show the file in the file explorer. This works even if the file was launched from search or a shortcut. This PR may not be necessary |
@harshad1 , Does your PR have the feature to restore scroll position of file list? If not, I can only keep this feature in this PR. |
In addition, I hope the feature in your PR can highlight recently opened folders, rather than only documents. |
app/src/main/java/net/gsantner/opoc/frontend/filebrowser/GsFileBrowserListAdapter.java
Show resolved
Hide resolved
app/src/main/java/net/gsantner/opoc/frontend/filebrowser/GsFileBrowserListAdapter.java
Show resolved
Hide resolved
No. All I have is the ability to jump from an open file to it's location in the folder. I also like how the highlighting to show the file / folder looks. There are some good changes in this PR. I will think about this more. |
I'm still not sure which code should be kept in my PR. Perhaps, I think I can decide it after your PR #2176 is merged. |
PR has conflicts. might be easier to take version from msater and just make the few line changes again |
…into highlight-item # Conflicts: # app/src/main/java/net/gsantner/opoc/frontend/filebrowser/GsFileBrowserListAdapter.java
@gsantner . Conflicts has been resolved. |
app/src/main/java/net/gsantner/opoc/frontend/filebrowser/GsFileBrowserListAdapter.java
Show resolved
Hide resolved
app/src/main/java/net/gsantner/markor/format/asciidoc/AsciidocActionButtons.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many merge requests - regarding blinking and showing position in the list: Let's bring it all together on master now, and further improve/debloat it afterwards.
When dark theme is used, I find the white blink color bad.
I will improve it. |
This PR mainly implemented the following features for file browser:
The screen recording as follows:
restore-position-and-highlight.mp4