Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open resources in a tag #2275

Closed
wants to merge 2 commits into from
Closed

Conversation

harshad1
Copy link
Collaborator

@harshad1 harshad1 commented Apr 21, 2024

This PR allows the open link action to open a resource in a HTML tag.

For example: Place the cursor inside an audio attachment <audio src='foo'>Title</audio> and press the open link action to open the audio file foo

@@ -147,6 +147,12 @@ public void onRestoreInstanceState(final Bundle savedInstanceState) {
_quicknote = (DocumentEditAndViewFragment) manager.getFragment(savedInstanceState, Integer.toString(R.id.nav_quicknote));
_todo = (DocumentEditAndViewFragment) manager.getFragment(savedInstanceState, Integer.toString(R.id.nav_todo));
_more = (MoreFragment) manager.getFragment(savedInstanceState, Integer.toString(R.id.nav_more));

final NewFileDialog nf = (NewFileDialog) manager.findFragmentByTag(NewFileDialog.FRAGMENT_TAG);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preserving callback, fixes #2250

@harshad1
Copy link
Collaborator Author

Closing as I have merged this into #2277 (there were conflicts)

@harshad1 harshad1 closed this May 10, 2024
@harshad1 harshad1 deleted the open_links_in_tags branch August 18, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant