Refactor: naming conventions #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -94,7 +94,7 @@ In this document, all remarkable changes are listed. Not mentioned are smaller c | |||
|
|
|||
| ## 0.4.2 | |||
|
|
|||
| - users are now allowed to save `None` buffers for a `GGRSRequest::SaveRequest`. This allows users to keep their own state history and load/save more efficiently | |||
| - users are now allowed to save `None` buffers for a `GgrsRequest::SaveRequest`. This allows users to keep their own state history and load/save more efficiently | |||
There was a problem hiding this comment.
Maybe skip the changelog, since we can't change naming for released versions?
There was a problem hiding this comment.
I think this should remain as is. It's more of a historical listing than anything else :)
Co-authored-by: Johan Klokkhammer Helsing <johanhelsing@gmail.com>
Co-authored-by: Johan Klokkhammer Helsing <johanhelsing@gmail.com>
johanhelsing
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prepare for the next release, it's time to introduce breaking changes!
According to the rust naming conventions, Acronyms should not be fully uppercase. We already do this in bevy_ggrs, now it is time to also implement that change here.
GGRSErrortoGgrsErrorGGRSEventtoGgrsEventGGRSRequesttoGgrsRequestGgrsErrorvariants