Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Readme #16

Closed
ankurbhatia24 opened this issue Oct 27, 2019 · 11 comments
Closed

Update Readme #16

ankurbhatia24 opened this issue Oct 27, 2019 · 11 comments
Assignees
Labels
type: enhancement New feature or request
Milestone

Comments

@ankurbhatia24
Copy link

Please update the readme with instructions for Ubuntu 18 and ROS Melodic.

@welcome
Copy link

welcome bot commented Oct 27, 2019

Thanks for opening your first issue here! Make sure that no other issues on the same topic have already been opened!

@ankurbhatia24
Copy link
Author

ankurbhatia24 commented Oct 27, 2019

Checkout the logs after catkin build: https://gist.github.com/AKR2470/012c17bd2d392df47ae063d837f04ace

@gsilano gsilano self-assigned this Oct 28, 2019
@gsilano
Copy link
Owner

gsilano commented Oct 28, 2019

Hi @AKR2470! First of all, thanks for using CrazyS. Then, as far as your request is concerned, as you can read from the reference papers, CrazyS uses as a basis RotorS: an existing ROS package (developed by ETH Zurich) which aims to simulate the behavior of aerial platforms (and also sensors) when control algorithms are in the loop.

At the time of development - I know that something happened in the middle, but nothing official - RotorS was available only for the Indigo Igloo and Kinetic Kame distros of ROS. Therefore, we decided to develop our contribution for these two software releases of ROS.

However, apart from the history behind the package, starting from your question I found open issues on the RotorS GitHub repo. It seems that they are going ahead, but I'm not sure. In the meantime, I suggest you downgrade your ROS distro and starting with Kinetic.

I opened a milestone (6.0.0) and branch (dev/ros-melodic) on CrazyS, as well. I linked them to a pull request and will examine the possibility of adapting CrazyS to the Melodic distro of ROS.

I hope to reply you soon.

@gsilano gsilano added this to the 6.0.0 milestone Oct 28, 2019
@gsilano gsilano added status: in progress This issue is being addressed already. To be applied to issues if they have a open PR type: enhancement New feature or request labels Oct 28, 2019
@antbono
Copy link

antbono commented Dec 9, 2019

It would be great to have this package available with ros melodic and gazebo 9!!! More realistic simulation setups are now possibile with the latest tools of matlab/simulink :)

@gsilano
Copy link
Owner

gsilano commented Dec 10, 2019

The package is already compatible with Gazebo 9. You can install the 3D environment on ROS Kinetic by following this guide.

@antbono
Copy link

antbono commented Dec 10, 2019

Thank you for this info! I'm going to try it :)
@gsilano, unfortunately, i can't compile the CrazyS package with gazebo9 installed. It requires some libraries of gazebo7 but you can't install these packages because they depend on gazebo7 and the system seems to not accept two installations of Gazebo. Did you try in your system to compile the package? Thank you :)

@gsilano
Copy link
Owner

gsilano commented Dec 12, 2019

I'm working on this issue. I opened a proper branch (dev/gazebo9) for containing the code.

@gsilano
Copy link
Owner

gsilano commented Dec 13, 2019

Hi @antbono!! I have almost completed the migration from Gazebo 7 to 9. As soon as the last tests have been completed, I will commit the code on GitHub. Would you like to be my beta tester? I would like to understand if I missed something in the list of commands to run RotorS, and therefore CrazyS, with Gazebo 9. Thanks!!

@antbono
Copy link

antbono commented Dec 14, 2019

Yes for sure! :D I can't promise anything about the timing, but I'll definitely want to try it! :D
(same holds for the BebopS package :)

@gsilano gsilano modified the milestones: 7.0.0, 5.0.1, 6.0.1 Dec 28, 2019
@gsilano gsilano removed the status: in progress This issue is being addressed already. To be applied to issues if they have a open PR label Dec 28, 2019
@gsilano
Copy link
Owner

gsilano commented Dec 28, 2019

Hi @AKR2470!! I just uploaded the instructions in the README.md to use the package with ROS Melodic and Gazebo 9.

Hi @antbono, I have tested the package and fixed the issues you described. Now, the CrazyS is full compatible with Gazebo 9 and ROS Kinetic Kame. If you have time, don't hesitate to try my guide and highlight typos and / or mistakes.

So, I will close this issue as resolved. Please feel free to open another if problems appear.

@gsilano gsilano closed this as completed Dec 28, 2019
@ankurbhatia24
Copy link
Author

@gsilano Thank you! I'll surely checkout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants