Fix: [OV-44493] - action menu - fixed keyboard navigation (#440)

* Fix: [OV-44493] - action menu - fixed keyboard navigation
gsoft-inc · Jun 19, 2023 · 957387b · 957387b
1 parent 0482ec6
commit 957387b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/.changeset/real-clouds-drum.md b/.changeset/real-clouds-drum.md
@@ -0,0 +1,5 @@
+---
+'@igloo-ui/action-menu': patch
+---
+
+Other props for the action menu reference were overriding the onKeyDown event. Rearranged the order to fix this.
diff --git a/packages/ActionMenu/src/ActionMenu.tsx b/packages/ActionMenu/src/ActionMenu.tsx
@@ -245,10 +245,12 @@ const ActionMenu: React.FunctionComponent<ActionMenuProps> = ({
  onClose={() => toggleMenu(false)}
  renderReference={(refProps: React.HTMLProps<HTMLButtonElement>) => {
  return renderReference({
+ ...refProps,
  onClick: () => toggleMenu(!showMenu),
- onKeyDown: handleOnKeyDown,
+ onKeyDown: (e) => {
+ handleOnKeyDown(e);
+ },
  className: 'ids-action-menu__trigger',
- ...refProps,
  });
  }}
  />