Feature/csf #1050
Merged
Feature/csf #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
October 20, 2022 15:58
✅ Deploy Preview for sg-storybook ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for sg-orbit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
added 2 commits
October 31, 2022 13:49
packages/components/src/alert/tests/chromatic/AlertTrigger.chroma.jsx
Outdated
Show resolved
Hide resolved
packages/components/src/avatar/tests/chromatic/Avatar.chroma.jsx
Outdated
Show resolved
Hide resolved
added 5 commits
November 4, 2022 11:13
… and click as they are not useful on 14.4.0
| @@ -9,6 +9,7 @@ import { Tooltip, TooltipTrigger } from "../../tooltip"; | |||
| const DefaultElement = "div"; | |||
|
|
|||
| export interface InnerAvatarGroupProps extends Omit<AbstractGroupProps<typeof DefaultElement>, "gap" | "orientation"> { | |||
| remainingAvatarsProps?: any; | |||
There was a problem hiding this comment.
Note for myself:
Is this prop ok? was there a comment about it earlier?
The typing is wrong here
packages/components/src/avatar/tests/chromatic/AvatarGroup.chroma.jsx
Outdated
Show resolved
Hide resolved
packages/components/src/badge/tests/chromatic/BadgeCount.chroma.jsx
Outdated
Show resolved
Hide resolved
packages/components/src/badge/tests/chromatic/BadgeDot.chroma.jsx
Outdated
Show resolved
Hide resolved
packages/components/src/button/tests/chromatic/CrossButton.chroma.jsx
Outdated
Show resolved
Hide resolved
packages/components/src/checkbox/tests/jest/CheckboxGroup.test.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/date-input/tests/jest/DateInput.test.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/date-input/tests/jest/DateRangeInput.test.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/dialog/tests/chromatic/Dialog.chroma.jsx
Outdated
Show resolved
Hide resolved
packages/components/src/listbox/tests/chromatic/Listbox.chroma.jsx
Outdated
Show resolved
Hide resolved
packages/components/src/styling/tests/chromatic/ThemeProvider.chroma.jsx
Outdated
Show resolved
Hide resolved
alexasselin008
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Summary
Storybook it moving toward CSF, and won't support anything else from Storybook 7, our tests needed to be converted.
What I did
Converted to CSF file format (https://storybook.js.org/docs/react/api/csf) stories that were not dynamically generating stories.