Feature/idp 1028 treat warning as error flag #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 14, 2024 15:26
asimmon
reviewed
Mar 15, 2024
src/Workleap.OpenApi.MSBuild/msbuild/tools/Workleap.OpenApi.MSBuild.targets
Outdated
Show resolved
Hide resolved
asimmon
reviewed
Mar 15, 2024
asimmon
reviewed
Mar 15, 2024
asimmon
reviewed
Mar 15, 2024
heqianwang
approved these changes
Mar 18, 2024
Co-authored-by: heqianwang <158102624+heqianwang@users.noreply.github.com>
heqianwang
approved these changes
Mar 18, 2024
PrincessMadMath
deleted the
feature/idp-1028_treat_warning_as_error_flag
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Support the property. If OasDiff or Spectral step validation fail it will log errror instead of warning.
Add option to opt-out with OpenApiIgnoreErrors
Breaking changes
Yes, if this library was logging warning in a current project and they use the TreatWarningsAsErrors flag it will fail their build.
Additional checks