BF: libiconv does not support undashed unicode encoding aliases #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Nice catch! |
Signed-off-by: kchaniveckyga <kchaniveckyga@fortinet.com>
Contributor
Author
Done! |
Collaborator
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description
In commit Use UCS16LE instead of UCS-2LE UCS2LE was swapped for UTF16LE. This change works fine if libunistring is using the GLIBC iconv_* symbols. However, if libunistring is linked to libiconv instead, the change breaks this library.
In the libiconv manual there is no explicit mention to aliases without dashes being supported, and testing revealed that it in fact does not. https://www.gnu.org/software/libiconv/
Solution
Replace "UTF16LE" with "UTF-16LE" in libunistring calls
Test