tests: Catch errors during tests setup #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simo5
reviewed
Aug 6, 2020
tests/magtests.py
Outdated
| @@ -801,7 +801,10 @@ def test_mech_name(testdir, testenv, logfile): | |||
| processes = dict() | |||
| logfile = open(os.path.join(testdir, 'tests.log'), 'w') | |||
| errs = 0 | |||
| is_not_setup = True | |||
There was a problem hiding this comment.
By "is_not_setup" you mean the script "is not in the setup phase" ?
It's a bit confusing to work by negatives, I would rather have a guard named setup_phase = True, and at the end you set setup_phase = False
However an even simpler way to deal with this i to set errs to -1 and then clear it with a comment that says why before starting tests.
There was a problem hiding this comment.
Good idea! changed to 'errs=-1'. Thank you.
| @@ -15,7 +15,7 @@ elif [ -f /etc/fedora-release ]; then | |||
| dnf -y install $COMPILER python3-{gssapi,requests{,-gssapi},flake8} \ | |||
| krb5-{server,workstation,pkinit} curl libfaketime \ | |||
| {httpd,krb5,openssl,gssntlmssp}-devel {socket,nss}_wrapper \ | |||
| autoconf automake libtool which bison make python3 \ | |||
| autoconf automake libtool which bison make python3 python3-devel \ | |||
There was a problem hiding this comment.
looks ok to me but I'd defer to @frozencemetery on this
stanislavlevin
force-pushed
the
catch_setup_errors
branch
from
2eac89e to
474a92c
Compare
Fixes: gssapi#224 Signed-off-by: Stanislav Levin <slev@altlinux.org>
python3-devel is required to build python-gssapi within virtualenv. Signed-off-by: Stanislav Levin <slev@altlinux.org>
stanislavlevin
force-pushed
the
catch_setup_errors
branch
from
474a92c to
30c5dc7
Compare
frozencemetery
approved these changes
Aug 6, 2020
| @@ -15,7 +15,7 @@ elif [ -f /etc/fedora-release ]; then | |||
| dnf -y install $COMPILER python3-{gssapi,requests{,-gssapi},flake8} \ | |||
| krb5-{server,workstation,pkinit} curl libfaketime \ | |||
| {httpd,krb5,openssl,gssntlmssp}-devel {socket,nss}_wrapper \ | |||
| autoconf automake libtool which bison make python3 \ | |||
| autoconf automake libtool which bison make python3 python3-devel \ | |||
simo5
approved these changes
Aug 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #224