crypto: Handle EVP changes in OpenSSL 3 #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robbie Harwood <rharwood@redhat.com>
OpenSSL 3 changes the padding behavior of EVP_DecryptFinal_ex(), which causes our decryption to fail. It is the opnion of the OpenSSL developers that mod_auth_gssapi's use of this function was incorrect. Patch suggested by Tomáš Mráz. Related: openssl/openssl#16351 Signed-off-by: Robbie Harwood <rharwood@redhat.com>
|
Yeah definitely a bug on our side which we never fell for before because OpenSSL 1.1.1 basically never deferred filling the buffer till the Final call ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenSSL 3 changes the padding behavior of EVP_DecryptFinal_ex(), which
causes our decryption to fail. It is the opnion of the OpenSSL
developers that mod_auth_gssapi's use of this function was incorrect.
Patch suggested by Tomáš Mráz.
Related: openssl/openssl#16351
Signed-off-by: Robbie Harwood rharwood@redhat.com