-
Notifications
You must be signed in to change notification settings - Fork 290
Add .Net Core support #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… ported. All tests passed except a skipped one due to Thread.set_CurrentCulture() unsupported on dnxcore.
…on creating and updating the dependencies in .nuspec file.
This looks interesting. Do you consider the pull request complete or will you be adding more to this? |
[Oops wrong sign-in in previous comment] |
I've had a look at all the changes now. There are more compile time ifdef's than I expected. Granted, I haven't really worked with the open source dotnet before, but I thought they were more compatible than this. Is there a way to rewrite some of the code so that it would work for both? |
The overwhelming majority of the ifdefs seem to fall under two categories: reflection and stringcomparer. It looks like @jeremymeng used them to avoid making backwards-incompatible changes to the non-core build, which is definitely appreciated, but given that we're still in beta for 2.0 I vote to use whichever option works on both platforms. In the |
Yes, the only reason is that I wanted to keep the Desktop code intact. I will take a look to make improvements. |
…s that are incompatible.
…atible with the NETCore meta packages referenced by the PCL project.
@nemec are we waiting for 2.0 to go stable before merging this? |
I replaced |
…port dotnet even the portable profile 259 is compatible. Add a paket.references file for the CommandLine.dotnet project. Rest of chagnes are done by paket.
The new Help on the Fake integration is welcome. |
Keen for this. @jeremymeng @mizipzor what is need for this to be merged? |
Any updates on this? We would like to use this in a .NET Core application. |
While we wait for this pr you can use my port from myget feed here |
Given recent developments this pull request will need a bit of work to support the new csproj for Core. To be honest, I'm a bit hesitant to even merge support into master until, at the very least, 1.0 is out the door. Even at this late stage there's still a lot of churn. What if we moved work on this to a |
I don't think thats right though the csproj setup has been release yet at all. The current setup of project.json allows multi target framework versions, e.g. 2, 3.5, 4, 4.5, netstandard etc. As others do you can keep the exact same setup re: sln's and csprojs just add a new sln,xproj,project.json for vs2015. Use ifdefs and extension methods to change code for version targeting and also use the include and exclude files build options in project.json. If you like I can push up my branch to show you what I mean but I don't see a reason not to support netstandard but if you are not happy to merge it that's fine too. |
The csproj changes are only for build-specific options, like compiler options. Dependencies, target frameworks, etc., will still be managed in project.json so I doubt the planned changes for VS15 RTW will make any difference to the PR. |
Sounds like a good idea. Even better if alpha packages can be released from that branch to early adopters. |
Okay it's been merged into the branch Regarding Nuget packages, I'm on Linux at the moment and Nuget keeps wanting to use backslashes, which are not path separators, so it's breaking. @gsscoder may be coming back tomorrow (see #291) and may be able to help with that. He's also the only one with access to the Nuget repository. |
Did you push |
Like @pawelsawicz , also looking for this. There are a lot of clone/forked versions on nuget, lots of with the same name as well. Trying to figure out of one of them is the "real" .net core version. |
@pawelsawicz and others, I've created an unofficial nuget package from master and I'm using it in a .NET core app project with success. You can find it at: https://www.nuget.org/packages/CommandLineParser.Unofficial.CoreBeta/2.1.0-beta I understand that the owner of the official nuget package is very busy, so I created this in the meantime, but please @nemec or others ping me when 2.1-* gets officially pushed and at that point we can discuss if it's best to pull this to get people back on the correct package. |
This is for #237.
Open issue:
Add 'dotnet' and its dependencies to the .nuspec.I know little about Fake. Also I am not sure how well it supports the new .NET Core based test project. so any helps are welcome!