Skip to content

Fixing project refs so tests build on dotnet core #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2016
Merged

Fixing project refs so tests build on dotnet core #340

merged 1 commit into from
Aug 7, 2016

Conversation

kbrooks
Copy link

@kbrooks kbrooks commented Aug 5, 2016

Tests wouldn't build on dotnet core because the root global.json was set up incorrectly to use the "target": "project" dependency style.

I've fixed this and I verified that the tests can run and pass on dotnet core.

This resolves issue #330

@nemec nemec merged commit 2ea80f6 into gsscoder:dotnet-core Aug 7, 2016
@nemec
Copy link
Collaborator

nemec commented Aug 7, 2016

Fantastic. I can now build and run the tests on Linux! I think we're ready to merge this branch into Master.

@kbrooks
Copy link
Author

kbrooks commented Aug 8, 2016

@nemec do you know when the dotnet core support will be available on nuget?

@nemec
Copy link
Collaborator

nemec commented Aug 9, 2016

Unfortunately, only the repo owner can access the NuGet repository to upload a new package and he's away for a while (#291). If @Mizipzor has time, maybe he could pack one and create a release for it. It won't be as nice as on NuGet proper, but hosting your own NuGet "feed" as a local folder is incredibly easy. It will also upgrade cleanly in VS when we are able to post v2.0.0.1 or whatever to the official repo.

@kbrooks kbrooks deleted the dotnet-core branch August 9, 2016 19:33
@shakdoesgithub
Copy link

Do we know if this will be published to nuget?
Is the repo owner back?

@nemec
Copy link
Collaborator

nemec commented Oct 27, 2016

He's still MIA. Once I get back from traveling next week my first order of business will be to create a new official nuget package for this project.

@shakdoesgithub
Copy link

Sounds good, Looking forward to it!

@shakdoesgithub
Copy link

@kbrooks how do you build this in dotnetcore?

@kbrooks
Copy link
Author

kbrooks commented Oct 27, 2016

I made a private nuget repo just for this thing lol

@shakdoesgithub
Copy link

Yeah, I'm going to go down that route until it's published to the public nuget.
Can you guide me how to build this? I'm running on a mac, so I don't have visual studio IDE, I do have dotnet core and mono installed.

@kbrooks
Copy link
Author

kbrooks commented Oct 27, 2016

Use the dotnet cli to create a nupkg, then pop it in a private nuget repo or just reference the file directly from your nuget config. I changed jobs recently so I can't look at what I set up.

@nemec
Copy link
Collaborator

nemec commented Oct 27, 2016

Try this. Last time I checked, MASTER builds through the dotnet cli on Linux without issues.
https://docs.microsoft.com/en-us/dotnet/articles/core/tools/dotnet-pack

@shakdoesgithub
Copy link

so this is what I've tried:
On master branch
1.) ./build.sh (fails on tests portion)

On dotnet-core branch
1.) ./build.sh (succeeds)
2.) cd /src/commandline/
3.) dotnet restore
4.) dotnet pack
5.) nuget publish nuget ./bin/Debug/CommandLine.2.0.275.nupkg

So it works on the dotnet-core branch, but not on the master.
Maybe i'm missing something

@erick-thompson
Copy link

Awesome! I'm looking forward to using this in my .net core projects!

@erick-thompson
Copy link

Does anyone have a built nuget package uploaded anywhere? I have a private nuget server, and don't want to wait for the official package.

@nemec
Copy link
Collaborator

nemec commented Nov 5, 2016

@erick-thompson
Copy link

Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants