-
Notifications
You must be signed in to change notification settings - Fork 290
Fixing project refs so tests build on dotnet core #340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fantastic. I can now build and run the tests on Linux! I think we're ready to merge this branch into Master. |
@nemec do you know when the dotnet core support will be available on nuget? |
Unfortunately, only the repo owner can access the NuGet repository to upload a new package and he's away for a while (#291). If @Mizipzor has time, maybe he could pack one and create a release for it. It won't be as nice as on NuGet proper, but hosting your own NuGet "feed" as a local folder is incredibly easy. It will also upgrade cleanly in VS when we are able to post v2.0.0.1 or whatever to the official repo. |
Do we know if this will be published to nuget? |
He's still MIA. Once I get back from traveling next week my first order of business will be to create a new official nuget package for this project. |
Sounds good, Looking forward to it! |
@kbrooks how do you build this in dotnetcore? |
I made a private nuget repo just for this thing lol |
Yeah, I'm going to go down that route until it's published to the public nuget. |
Use the dotnet cli to create a nupkg, then pop it in a private nuget repo or just reference the file directly from your nuget config. I changed jobs recently so I can't look at what I set up. |
Try this. Last time I checked, MASTER builds through the dotnet cli on Linux without issues. |
so this is what I've tried: On dotnet-core branch So it works on the dotnet-core branch, but not on the master. |
Awesome! I'm looking forward to using this in my .net core projects! |
Does anyone have a built nuget package uploaded anywhere? I have a private nuget server, and don't want to wait for the official package. |
It's published now. https://www.nuget.org/packages/CommandLineParser/2.1.1-beta |
Awesome, thank you! |
Tests wouldn't build on dotnet core because the root global.json was set up incorrectly to use the "target": "project" dependency style.
I've fixed this and I verified that the tests can run and pass on dotnet core.
This resolves issue #330