removed turnoffGrouping only for the constructor that accepts format #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtgalone
added a commit
that referenced
this pull request
Apr 15, 2024
|
@rsegecin Thanks! I just released with your fix. |
|
thank you again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm sorry to bother again in a such a short notice but I caught something that could lead to an error.
"The constructor of CurrencyTextInputFormatter does not necessarily require the turnOffGrouping parameter, as this functionality can be managed through the format parameter instance itself. Including turnOffGrouping in the main constructor may introduce potential errors."
CurrencyTextInputFormatter.currency and CurrencyTextInputFormatter.simpleCurrency they are still keeping turnOffGrouping for the library functionality.
I've also changed the CurrencyTextInputFormatter to also accept olders intl dependencies from intl: '>=0.17.0-0 <=0.19.0'. Having intl since 0.17.0 won't affect CurrencyTextInputFormatter its the same range used by easy_localization package.