generate cfg conditions for aliases, enums, interfaces and disguised #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you mind submitting a PR to at least gtk-rs-core/gtk4-rs with the changes to see how it looks like? |
sdroege
approved these changes
Mar 20, 2023
|
Looks good to me but having a pre-view of the changes would be useful indeed. |
|
The CI should be fixed once gtk-rs/gtk3-rs#817 is merged |
|
Please rebase & squash the commits into one. |
…records Signed-off-by: fbrouille <fbrouille@users.noreply.github.com>
fbrouille
force-pushed
the
generate_cfg_conditions
branch
from
70d5f5a
to
ca0a030
Compare
|
This change does not impact generated code for |
|
Ok, let's merge it then. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.