-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace dox feature with docsrs attribute #1455
Conversation
I would also suggest documenting how cargo doc should be ran in the gir book if possible |
So sadly it will require to add a |
why a --feature is needed? i thought everything would be handled by the RUSTFLAGS? |
Sorry, you're right. Wrote too quickly. |
And |
Speaking of Everything else should be in place by now, I've pushed an update for the book earlier today. |
Oh right. But we set |
Is there still anything missing in this PR? |
@AaronErhardt Once merged, will you create PRs for gtk-rs-core and gtk4-rs at least to update accordingly? |
Sure |
Great, then let's get this in :) I can take care of gstreamer-rs once the others are in. |
Fixes #1454
I think this should be all from the gir side.
I've tested this branch on gtk4-rs and everything looked and worked great so far.
Let me know if I should submit PRs for various gtk-rs crates once this is merged.