-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update toml, regex and xml-rs version #320
Conversation
Fixed regex update |
Upgraded xml-rs |
@GuillaumeGomez I merge PR tomorrow if you do not see the problems |
Cargo.toml
Outdated
@@ -11,7 +11,7 @@ exclude = ["Gir*.toml", "tests/**/*", "*.md"] | |||
|
|||
[dependencies] | |||
docopt = "*" | |||
xml-rs = "0.2.1" | |||
xml-rs = "*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm clearly not a big fan of this. Also, we won't be able to publish we use '*' (even if we don't care).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to "0.2" and add version for others *?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes please. At least we'll have a bit more control over dependencies.
Except for my comment, I'm 100% 👍 |
Done. |
Not sure that we really needed same |
Was wrong about |
Ok. So like I said, it's good for me. Merge when you want to. |
Removed unneeded |
Updating to new last toml as
rustc-serialize
planed for deprecation https://internals.rust-lang.org/t/rust-release-milestone-predictions/4591Only last is
docopt
that also planing use serde docopt/docopt.rs#128PS. There was problem with sys crates toml-rs/toml-rs#151
PPS. When upgrading found that
regex 0.2.0
don't implementEq
so this code fails and upgrade will need other PR later (if any).