Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix enums from_glib unsafety, store unknown value #392

Merged
merged 1 commit into from
Jun 24, 2017
Merged

Fix enums from_glib unsafety, store unknown value #392

merged 1 commit into from
Jun 24, 2017

Conversation

EPashkin
Copy link
Member

@EPashkin EPashkin commented Jun 23, 2017 •
edited
Loading

Part of #123

cc @GuillaumeGomez, @sdroege

Make enums look as #123 (comment)

@sdroege
Copy link
Member

sdroege commented Jun 23, 2017

Looks good to me 👍

@EPashkin
Copy link
Member Author

@GuillaumeGomez Please, take look

@GuillaumeGomez
Copy link
Member

Looks good to me too!

@EPashkin EPashkin merged commit 3c73dd9 into gtk-rs:master Jun 24, 2017
@EPashkin EPashkin deleted the from_glib_safety branch June 24, 2017 19:17
@EPashkin EPashkin mentioned this pull request Jun 24, 2017
Merged
This was referenced Jun 25, 2017
Merged
Merged
Merged
Merged
@EPashkin EPashkin mentioned this pull request Jun 25, 2017
Merged
@EPashkin
Copy link
Member Author

Checked all PRs linked to this, CI passed too. 👍 for merge.

@GuillaumeGomez
Copy link
Member

Ok, let's start a merge fest!

@GuillaumeGomez
Copy link
Member

All merged. Thanks to both of you! ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EPashkin @sdroege @GuillaumeGomez