Try to fix Windows CI #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
force-pushed
the
windows-ci-fix
branch
6 times, most recently
from
fa44617 to
d4c595a
Compare
GuillaumeGomez
force-pushed
the
windows-ci-fix
branch
2 times, most recently
from
fc06781 to
c97d236
Compare
GuillaumeGomez
force-pushed
the
windows-ci-fix
branch
from
c97d236 to
30d2393
Compare
GuillaumeGomez
force-pushed
the
windows-ci-fix
branch
2 times, most recently
from
f62c423 to
1c85ced
Compare
.github/workflows/main.yaml
Outdated
Comment on lines
128
to
130
| - run: curl -O http://repo.msys2.org/msys/x86_64/msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz.sig | ||
| - run: pacman -U --noconfirm --config <(echo) msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz | ||
| - run: pacman --noconfirm -Syu base-devel mingw-w64-${{ matrix.arch }}-toolchain |
There was a problem hiding this comment.
Suggested change
| - run: curl -O http://repo.msys2.org/msys/x86_64/msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz.sig | |
| - run: pacman -U --noconfirm --config <(echo) msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz | |
| - run: pacman --noconfirm -Syu base-devel mingw-w64-${{ matrix.arch }}-toolchain | |
| - run: curl -O http://repo.msys2.org/msys/x86_64/msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz.sig | |
| - run: pacman -U --noconfirm --config <(echo) msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz | |
| - run: pacman --noconfirm -Syu base-devel mingw-w64-${{ matrix.arch }}-toolchain | |
those are mis-indentended as well
GuillaumeGomez
force-pushed
the
windows-ci-fix
branch
2 times, most recently
from
69eb6dd to
66f851b
Compare
|
I think something like this should work I didn't notice the if matrix.os=='window-latest' before... I think what would make sense is to split the job into a windows/linux one instead of having a bunch of conditions though |
GuillaumeGomez
force-pushed
the
windows-ci-fix
branch
from
66f851b to
9a9788f
Compare
|
Should we just disable the Windows CI for now here? gir doesn't do anything Windows-specific anyway, it would seem more useful to have a Windows CI for gtk-rs instead. |
18 tasks
|
I will comment out all the windows part. It's just broken beyond recovery and I think it'll be for a while. |
GuillaumeGomez
force-pushed
the
windows-ci-fix
branch
from
2dba00b to
b607c60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #985.