This repository has been archived by the owner on Jun 8, 2021. It is now read-only.
Don't store subclass impl/private data in an Option<T> #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't know the exact memory layout of the Option<T> in relation to T so can't easily go from a *const T to the surrounding *const Option<T>. Since nightly from 2020-02-12 using both pointer types interchangeably causes segmentation faults as their memory layouts are not actually compatible and never were, but due to some compiler changes this actually causes crashes at runtime now. See rust-lang/rust#69102 for details. As an Option<_> was only used for some paranoid runtime checks that are not really needed, simply store T directly as impl/private data of subclasses. This has the side-effect of having zero-sized impl/private data types to actually occupy zero bytes of memory, and in some other cases to save a few bytes of the allocation.
Instead of first reading it on the stack and the dropping it.
|
@GuillaumeGomez This wants another bugfix release btw, it's a quite bad bug and I don't fully understand why it didn't explode from the very beginning :) |
|
Indeed, thanks for coming up so quickly with this fix! 👍 |
|
I have a small additional fix tomorrow, so don't do a release just yet. Tomorrow :)
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
|
|
It's a bit late for a release you know... We still have a few details to discuss about as well! |
…te/impl data for subclasses GLib aligns the type private data to two gsizes so we can't safely store any type there that requires a bigger alignment.
|
👍 Thanks. |
|
Thanks for reviewing :) |
|
Released as 0.9.3 on crates.io |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't know the exact memory layout of the Option in relation to T
so can't easily go from a *const T to the surrounding *const Option.
Since nightly from 2020-02-12 using both pointer types interchangeably
causes segmentation faults as their memory layouts are not actually
compatible and never were, but due to some compiler changes this
actually causes crashes at runtime now.
See rust-lang/rust#69102 for details.
As an Option<_> was only used for some paranoid runtime checks that are
not really needed, simply store T directly as impl/private data of
subclasses.
This has the side-effect of having zero-sized impl/private data types to
actually occupy zero bytes of memory, and in some other cases to save a
few bytes of the allocation.
CC @EPashkin @GuillaumeGomez