gio: Add a method to get a stream of incoming connections to SocketListener #1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosmn
force-pushed
the
cmn/socket-listener-stream
branch
from
243fcda
to
c0a45d5
Compare
sdroege
reviewed
Jul 8, 2024
carlosmn
force-pushed
the
cmn/socket-listener-stream
branch
from
c0a45d5
to
b2d317b
Compare
|
Alright, updated. I think the change in Gir.toml is right, but it's the first time I've had to touch something like that. |
sdroege
reviewed
Jul 8, 2024
carlosmn
force-pushed
the
cmn/socket-listener-stream
branch
from
b2d317b
to
f4b72a1
Compare
sdroege
reviewed
Jul 8, 2024
carlosmn
force-pushed
the
cmn/socket-listener-stream
branch
from
f4b72a1
to
68d5827
Compare
carlosmn
force-pushed
the
cmn/socket-listener-stream
branch
2 times, most recently
from
7bab98a
to
a99b4cc
Compare
…stener This object provides a `Stream` over which we can iterate in order to accept connections in an async environment. This is analogous to the one provided by async-std's `TcpListener`.
carlosmn
force-pushed
the
cmn/socket-listener-stream
branch
from
a99b4cc
to
7792104
Compare
carlosmn
force-pushed
the
cmn/socket-listener-stream
branch
from
7792104
to
08b94be
Compare
|
Well after way too much trial-and-error, this should be good to go now, but I don't understand that "docs embed" check as it seems to be about some bit flags. |
There's something broken with that check. Every now and then it reports errors like this for no reason. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This object provides a
Streamover which we can iterate in order to accept connections in an async environment.This is analogous to the one provided by async-std's
TcpListener.This is an attempt at #1064. As I mention there, I think
SocketServiceis the wrong abstraction to use in async so this is implemented forSocketListener, so that thisincoming()is by itself an alternative toSocketService.The type that we return here feels pretty awkward but it's what this returns. The pattern with the source object feels like another instance of something that makes sense without easy async but with async Rust you'd create multiple objects? But maybe I don't see other use-cases for it here.