Fix the L #2
Merged
Fix the L #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR ! However, in the current master branch, this is |
|
Ooooooh, I see. |
|
Right, the breaking change. The updated crates would be accompanied by a blog post explaining that but it has bitten you in an unexpected way. I guess this PR might actually be good to apply now, while the crates are still at the current version. |
|
@gkoz: I'll push the master branches on crates tomorrow. I'll discover how the news system is working then ! :D |
|
@mdinger would you reopen the PR please. It does make sense to make the example work with the current crate versions. |
|
There you go |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Silly mistake with an unhelpful error. This makes the example work now. Reminds me of rust-lang/rust#13677