This repository has been archived by the owner on Jun 8, 2021. It is now read-only.
Remove callback guard #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EPashkin
commented
Jun 23, 2018
| @@ -10,8 +10,7 @@ while (/^(\N*)\V*fn\s+(\w+)\s*(<[^(]+>)?\s*(\([^{;]+)\{\N*\n^(\N*)$/gms) { | |||
| $first_line =~ /^\s*( | |||
| assert_initialized_main_thread | | |||
| assert_not_initialized | | |||
| skip_assert_initialized | | |||
| callback_guard | |||
| skip_assert_initialized | |||
There was a problem hiding this comment.
unsafe functions just not checked, so this line not worked anyway
EPashkin
commented
Jun 23, 2018
| let _guard = ::glib::CallbackGuard::new(); | ||
| if cfg!(debug_assertions) { | ||
| assert_initialized_main_thread!(); | ||
| } |
There was a problem hiding this comment.
I slightly worry about this check, maybe it really needed
|
Yes but it should not be in the callback guard macro. I thought there was another macro for that? |
|
This macro named |
|
They are and it makes no sense to check that in the callback. It would be a gtk bug and not ours, not something we should try to detect |
|
Ok, then I think that PR is ready |
vhdirk
pushed a commit
to vhdirk/gtk-rs
that referenced
this pull request
Jan 16, 2019
Remove callback guard
Merged
alex179ohm
pushed a commit
to alex179ohm/gtk
that referenced
this pull request
Oct 21, 2019
Start of user callbacks generation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of gtk-rs/glib#250
cc @GuillaumeGomez, @sdroege