-
-
Notifications
You must be signed in to change notification settings - Fork 88
ABI tests are failing #54
Comments
The abi checks also fail on Windows. I disabled the sys tests for all crates except cairo in #256 |
@pbor Can you add the failures here? |
You can see the output in this run: https://github.com/pbor/gtk-rs/runs/1801152489?check_suite_focus=true Now that I check it, we might be running in something simpler since it is just not finding a file... |
Maybe that's not finding the C compiler? |
What fails here must be fn get_c_value(dir: &Path, cc: &Compiler, name: &str) -> Result<String, Box<dyn Error>> {
let exe = dir.join("constant");
let mut cc = cc.clone();
cc.define("ABI_CONSTANT_NAME", name);
cc.compile(Path::new("tests/constant.c"), &exe)?; <------ and then leading to pub fn compile(&self, src: &Path, out: &Path) -> Result<(), Box<dyn Error>> {
let mut cmd = self.to_command();
cmd.arg(src);
cmd.arg("-o");
cmd.arg(out);
let status = cmd.spawn()?.wait()?; <------ One of the But in the end this means that |
There are a couple things going on here. First, we need to avoid building egl/wayalnd/x11 crates on windows as they can't be built. Then we need to avoid running -sys tests as they don't succeed currently. See [1] Finally use a matrix:parallel job to tests multiple build configurations. [1] gtk-rs/gtk3-rs#54 Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-rs/-/merge_requests/701>
I am not sure why this issue is open on gtk3-rs when it is about glib (gtk-rs-core) stuff. Anyway, those tests are enabled & fixed now |
The text was updated successfully, but these errors were encountered: