Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a note to the book #1331

Merged
merged 3 commits into from
Mar 15, 2023
Merged

Add a note to the book #1331

merged 3 commits into from
Mar 15, 2023

Conversation

mashomee
Copy link
Contributor

Hofer-Julian
Hofer-Julian reviewed Mar 15, 2023
View reviewed changes
Copy link
Collaborator

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise

book/src/composite_templates.md Outdated Show resolved Hide resolved
@mashomee
Copy link
Contributor Author

mashomee commented Mar 15, 2023 •
edited
Loading

Should I open another pull request, or this one just ok?

Hofer-Julian
Hofer-Julian approved these changes Mar 15, 2023
View reviewed changes
Copy link
Collaborator

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This one is fine, I will merge it now :)

@Hofer-Julian Hofer-Julian merged commit 73b5f92 into gtk-rs:master Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hofer-Julian Hofer-Julian Hofer-Julian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mashomee @Hofer-Julian