Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos and deprecations in the book for CSS chapter (14th). #1334

Merged
merged 2 commits into from
Mar 17, 2023
Merged

Fix typos and deprecations in the book for CSS chapter (14th). #1334

merged 2 commits into from
Mar 17, 2023

Conversation

zekefast
Copy link
Contributor

Overview

Fix typos and deprecations in the book for CSS chapter (14th).

Changes:

  • Fix deprecation warnings in listings for CSS chapter of the book by replacing usage of Widget::show method with Window::present like it was done in other chapters.
  • Change used CSS class name from button_1 to button-1 in listing 3 of 14th chapter (CSS).

NOTE: StyleContext was also deprecated in GTK 4.10 and I found this discussion about moving gtk_style_context_add_provider to gtkstyleprovider.h but I haven't figured out how that change is reflected in gtk4-rs and how to use StyleProvider. So I left deprecations warnings about usage of StyleContext and it's functions unfixed.

Hofer-Julian
Hofer-Julian approved these changes Mar 17, 2023
View reviewed changes
Copy link
Collaborator

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @zekefast!

@Hofer-Julian
Copy link
Collaborator

NOTE: StyleContext was also deprecated in GTK 4.10 and I found this discussion about moving gtk_style_context_add_provider to gtkstyleprovider.h but I haven't figured out how that change is reflected in gtk4-rs and how to use StyleProvider. So I left deprecations warnings about usage of StyleContext and it's functions unfixed.

@bilelmoussaoui any ideas about this?

@Hofer-Julian Hofer-Julian merged commit dffc456 into gtk-rs:master Mar 17, 2023
@bilelmoussaoui
Copy link
Member

NOTE: StyleContext was also deprecated in GTK 4.10 and I found this discussion about moving gtk_style_context_add_provider to gtkstyleprovider.h but I haven't figured out how that change is reflected in gtk4-rs and how to use StyleProvider. So I left deprecations warnings about usage of StyleContext and it's functions unfixed.

@bilelmoussaoui any ideas about this?

See #1317

@Hofer-Julian
Copy link
Collaborator

NOTE: StyleContext was also deprecated in GTK 4.10 and I found this discussion about moving gtk_style_context_add_provider to gtkstyleprovider.h but I haven't figured out how that change is reflected in gtk4-rs and how to use StyleProvider. So I left deprecations warnings about usage of StyleContext and it's functions unfixed.

@bilelmoussaoui any ideas about this?

See #1317

So it's a false positive?

@bilelmoussaoui
Copy link
Member

Yes

@zekefast
Copy link
Contributor Author

zekefast commented Mar 17, 2023 •
edited
Loading

@Hofer-Julian So, no fixes to the book are needed so far. It should be resolved once #1317 is closed, right?

@zekefast zekefast deleted the fix-book-deprecations-and-typos branch March 17, 2023 21:01
@Hofer-Julian
Copy link
Collaborator

Exactly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hofer-Julian Hofer-Julian Hofer-Julian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zekefast @Hofer-Julian @bilelmoussaoui