Adapt to glib::Inhibit removal #1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bilelmoussaoui
force-pushed
the
bilelmoussaoui/no-inhibit
branch
from
fef61ff
to
cf3885c
Compare
andy128k
reviewed
Jul 24, 2023
| @@ -41,7 +40,7 @@ fn build_ui(application: >k::Application) { | |||
| if let Some(application) = window.application() { | |||
| application.remove_window(window); | |||
| } | |||
| Inhibit(false) | |||
| ControlFlow::Break | |||
There was a problem hiding this comment.
Shouldn't this be ControlFlow::Continue?
There was a problem hiding this comment.
Very possibly, I will check tomorrow
There was a problem hiding this comment.
After looking at related changes I may say the change is correct.
But wording seems misleading. "Inhibit" is closer to "Break" (or "Stop" or "Prevent").
The GTK doc of a signal close-request says:
Return value
Type: gboolean
TRUE to stop other handlers from being invoked for the signal.
It seems natural to use Break to represent Inhibit(true) and Continue to represent Inhibit(false).
There was a problem hiding this comment.
Would you mind opening an issue about this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on gtk-rs/gtk-rs-core#1126