Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate listings to action group #1525

Merged
merged 5 commits into from
Oct 30, 2023

Conversation

Hofer-Julian
Copy link
Collaborator

No description provided.

.get::<i32>()
.expect("The variant needs to be of type `i32`.");
let action_count = ActionEntry::builder("count")
.parameter_type(Some(&i32::static_variant_type()))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why Some? is this takes an Option??

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes: https://gtk-rs.org/gtk-rs-core/stable/latest/docs/gio/struct.ActionEntryBuilder.html

If you want to make me a bit happier, then please open a PR/MR at the right place 😅

@Hofer-Julian Hofer-Julian marked this pull request as ready for review October 27, 2023 18:13
@Hofer-Julian Hofer-Julian merged commit fd5d2ee into master Oct 30, 2023
3 checks passed
@Hofer-Julian Hofer-Julian deleted the Hofer-Julian/migrate-action-group branch October 30, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants