Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust mobile view on https://docs.guac.sh/setup/ #163

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sarthak-kumar-shailendra
Copy link

@sarthak-kumar-shailendra sarthak-kumar-shailendra commented Oct 21, 2024

[Fixes #162]

After changes

Screenshot 2024-10-21 at 10 05 11 PM https://docs.guac.sh/setup/ https://docs.guac.sh Screenshot 2024-10-21 at 10 13 35 PM

Copy link

netlify bot commented Oct 21, 2024

Deploy Preview for resonant-wisp-1a517a ready!

Name Link
🔨 Latest commit 9daf3b1
🔍 Latest deploy log https://app.netlify.com/sites/resonant-wisp-1a517a/deploys/671ab7c0859a160008eee0f6
😎 Deploy Preview https://deploy-preview-163--resonant-wisp-1a517a.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@funnelfiasco
Copy link
Collaborator

Hi, @sarthak-kumar-shailendra! Welcome to GUAC and thanks for the contribution. Before we can merge this, you need to do a couple of things

  1. Squash your two commits into one
  2. Signoff on the resulting commit (this is why the DCO check above is failing)

See https://garrytrinder.github.io/2020/03/squashing-commits-using-interactive-rebase if you need an example of how to squash your commits. If you need help, please feel free to ask in our Slack channel.

@funnelfiasco funnelfiasco self-requested a review October 24, 2024 17:23
Copy link
Collaborator

@funnelfiasco funnelfiasco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Necessary changes left as comment

Signed-off-by: sarthak-kumar-shailendra <sarthak.shailendra@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile View breaks for 3 pages
2 participants