[bug] toposort Loop Not Ending when Graph is Finished

[nathannaveen]

Describe the bug

On line 30 of pkg/guacanalytics/toposort.go:

guac/pkg/guacanalytics/toposort.go

Line 30 in bc5c042

for numNodes <= totalNodes {

I think that it shouldn't be numNodes <= totalNodes, and should actually be numNodes < totalNodes. The reason for this being on line 41:

guac/pkg/guacanalytics/toposort.go

Lines 41 to 43 in bc5c042

	if len(foundIDs) == 0 {
	return frontiers, fmt.Errorf("Error: cycle detected")
	}

We are checking for whether len(foundIDs) == 0. If numNodes == totalNodes then we have gone through all the nodes and have no more nodes to find, so len(foundIDs) will equal 0.

I am not sure whether this is intentional because the error message is fmt.Errorf("error: cycle detected"), even though in this case there will be no cycle.

[nathannaveen]

cc @rmetzman

[rmetzman]

#1129 This PR fixes the issue but it does not apply the change with the len(parents) from your other fix because the PR hasn't been merged yet.

[nathannaveen]

This gets fixed with #1129.