You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We are checking for whether len(foundIDs) == 0. If numNodes == totalNodes then we have gone through all the nodes and have no more nodes to find, so len(foundIDs) will equal 0.
I am not sure whether this is intentional because the error message is fmt.Errorf("error: cycle detected"), even though in this case there will be no cycle.
The text was updated successfully, but these errors were encountered:
Describe the bug
On line 30 of pkg/guacanalytics/toposort.go:
guac/pkg/guacanalytics/toposort.go
Line 30 in bc5c042
I think that it shouldn't be
numNodes <= totalNodes
, and should actually benumNodes < totalNodes
. The reason for this being on line 41:guac/pkg/guacanalytics/toposort.go
Lines 41 to 43 in bc5c042
We are checking for whether
len(foundIDs) == 0
. IfnumNodes == totalNodes
then we have gone through all the nodes and have no more nodes to find, solen(foundIDs)
will equal0
.I am not sure whether this is intentional because the error message is
fmt.Errorf("error: cycle detected")
, even though in this case there will be no cycle.The text was updated successfully, but these errors were encountered: