-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PatchPlanning] Add CLI cmd for patch planning #1129
Conversation
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
initial review comments
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nits , else LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @rmetzman. Will have to rebase on main for it to auto-merge
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Signed-off-by: Rebecca Metzman <rmetzman@google.com>
Description of the PR
PR Checklist
-s
flag togit commit
.make generate
has been runcollectsub
protobuf has been changed,make proto
has been run