Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Empty String Parents for Root Nodes #1131

Conversation

nathannaveen
Copy link
Contributor

Description of the PR

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@lumjjb
Copy link
Contributor

lumjjb commented Aug 7, 2023

@rmetzman would you like to take a review of this if you have some time?

@rmetzman
Copy link
Contributor

rmetzman commented Aug 7, 2023

@nathannaveen try running "go test" on the pkg/guacanalytics directory. I think something is causing the tests to fail according to the pre-submits.

* In pkg/guacanalytics/patchPlanning.go removed the empty string parents for root nodes. The explanation for this is: guacsec#1120 (comment)
* Changed q.now to a pointer
* Fixes guacsec#1120

Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
@nathannaveen nathannaveen force-pushed the nathan/fix/removeEmptyStringFromPatchPlanning branch from 30054b3 to 0bd4e3b Compare August 7, 2023 18:48
@nathannaveen
Copy link
Contributor Author

@nathannaveen try running "go test" on the pkg/guacanalytics directory. I think something is causing the tests to fail according to the pre-submits.

I got it to work now, Thanks!

@rmetzman
Copy link
Contributor

rmetzman commented Aug 8, 2023

Hi Nathan-- I merged a PR #1129 with some edits in the same files so I think this PR (and maybe a few of your others on these same files) require a rebase.

Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
@nathannaveen nathannaveen force-pushed the nathan/fix/removeEmptyStringFromPatchPlanning branch from 01684d6 to c89c587 Compare August 9, 2023 00:03
@nathannaveen
Copy link
Contributor Author

Hi Nathan-- I merged a PR #1129 with some edits in the same files so I think this PR (and maybe a few of your others on these same files) require a rebase.

Resolved the conflicts, Thanks!

@pxp928
Copy link
Collaborator

pxp928 commented Aug 9, 2023

@rmetzman did you want to re-review this?

Copy link
Contributor

@rmetzman rmetzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! LGTM

@nathannaveen
Copy link
Contributor Author

@pxp928 A friendly reminder!

Copy link
Collaborator

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kodiakhq kodiakhq bot merged commit a8e7ad3 into guacsec:main Aug 15, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] pkg/guacanalytics/patchPlanning.go fills in parent field for root nodes
4 participants