-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed Empty String Parents for Root Nodes #1131
Removed Empty String Parents for Root Nodes #1131
Conversation
@rmetzman would you like to take a review of this if you have some time? |
@nathannaveen try running "go test" on the pkg/guacanalytics directory. I think something is causing the tests to fail according to the pre-submits. |
* In pkg/guacanalytics/patchPlanning.go removed the empty string parents for root nodes. The explanation for this is: guacsec#1120 (comment) * Changed q.now to a pointer * Fixes guacsec#1120 Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
30054b3
to
0bd4e3b
Compare
I got it to work now, Thanks! |
Hi Nathan-- I merged a PR #1129 with some edits in the same files so I think this PR (and maybe a few of your others on these same files) require a rebase. |
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
01684d6
to
c89c587
Compare
Resolved the conflicts, Thanks! |
@rmetzman did you want to re-review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! LGTM
@pxp928 A friendly reminder! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of the PR
PR Checklist
-s
flag togit commit
.make generate
has been runcollectsub
protobuf has been changed,make proto
has been run