-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] pkg/guacanalytics/patchPlanning.go fills in parent field for root nodes #1120
Comments
Could I work on this? cc @pxp928 |
@rmetzman are you already working to fix this? |
Nope, I haven't started working on this yet. |
@nathannaveen assigning to you! |
I assume that the statement in the expected behavior part: " I am pretty sure that I have located the issue regarding where the root nodes having non empty parents is located. If we start inside the function Now we get to Line 80: guac/pkg/guacanalytics/patchPlanning.go Lines 80 to 86 in bc5c042
On line 87 we are also editing Now we have to go into the function Line 445: guac/pkg/guacanalytics/patchPlanning.go Lines 445 to 451 in bc5c042
We are setting Correct me if I am wrong, but I am pretty sure that this is the only place where |
Yes, this makes sense to me, I think that must be causing the issue. |
* In pkg/guacanalytics/patchPlanning.go removed the empty string parents for root nodes. The explanation for this is: guacsec#1120 (comment) * Changed q.now to a pointer * Fixes guacsec#1120 Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
Thank You! |
* In pkg/guacanalytics/patchPlanning.go removed the empty string parents for root nodes. The explanation for this is: guacsec#1120 (comment) * Changed q.now to a pointer * Fixes guacsec#1120 Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
* In pkg/guacanalytics/patchPlanning.go removed the empty string parents for root nodes. The explanation for this is: #1120 (comment) * Changed q.now to a pointer * Fixes #1120 Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
Describe the bug
pkg/guacanalytics/patchPlanning.go for the root/input nodes which should have an empty parents list, the program for some reason populated this field to contain an empty string.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
len(parentsList) should == 1 for the start nodes inputted
The text was updated successfully, but these errors were encountered: