Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] ClearlyDefinedTests are flaky #2290

Closed
lumjjb opened this issue Nov 13, 2024 · 2 comments · Fixed by #2306
Closed

[bug] ClearlyDefinedTests are flaky #2290

lumjjb opened this issue Nov 13, 2024 · 2 comments · Fixed by #2306
Labels
bug Something isn't working

Comments

@lumjjb
Copy link
Contributor

lumjjb commented Nov 13, 2024

Describe the bug
Clearly defined tests are flaky

To Reproduce

See failing CIs: https://github.com/guacsec/guac/actions/runs/11797715031/job/32862288131

Expected behavior

Tests should not flake

Screenshots
If applicable, add screenshots to help explain your problem.

GUAC version
NA

Additional context
Add any other context about the problem here.

@lumjjb lumjjb added the bug Something isn't working label Nov 13, 2024
@pxp928
Copy link
Collaborator

pxp928 commented Nov 18, 2024

TestPurlsLicenseScan is also being skipped as CD fails to respond in time.

@pxp928
Copy link
Collaborator

pxp928 commented Nov 18, 2024

To resolve this, we need to mock out the Clearly Defined service and run the unit tests against that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants