Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip clearly defined tests for now because of flake #2291

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

lumjjb
Copy link
Contributor

@lumjjb lumjjb commented Nov 13, 2024

Description of the PR

Workaround for #2290

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If GraphQL schema is changed, GraphQL client updates/additions have been made
  • If OpenAPI spec is changed, make generate has been run
  • If ent schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

Signed-off-by: Brandon Lum <lumjjb@gmail.com>
@kodiakhq kodiakhq bot merged commit c0fdd1c into main Nov 13, 2024
10 checks passed
@kodiakhq kodiakhq bot deleted the skip-clearlydefined-tests branch November 13, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants