Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add certifyBad query, certifyGood ingestion and query, update bulk assembler #1123

Merged
merged 4 commits into from
Aug 3, 2023
Merged

add certifyBad query, certifyGood ingestion and query, update bulk assembler #1123

merged 4 commits into from
Aug 3, 2023

Conversation

pxp928
Copy link
Collaborator

@pxp928 pxp928 commented Aug 3, 2023

Description of the PR

  • remove root src and pkg
  • add certifyBad query
  • add certifyGood ingestion and query
  • update bulk assembler to use certifyBad and certifyGood bulk ingest
  • Add ID matching to queries
  • update isDependency query to be more robust
  • Change query to search for multiple subjects

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • [] All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@pxp928
add query for certifyBad
cc0d920 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
remove root src and pkg and seperate query for subjects
0bd3629 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
add certifyGood to arango
d291623 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
update batch assembler to use certifyBad and certifyGood bulk ingestion
226974e 
Signed-off-by: pxp928 <parth.psu@gmail.com>
lumjjb
lumjjb approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@lumjjb lumjjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, love the querybuilder

@kodiakhq kodiakhq bot merged commit c0614ec into guacsec:main Aug 3, 2023
9 checks passed
@pxp928 pxp928 deleted the feature/arango-certify-good branch August 3, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@lumjjb lumjjb lumjjb approved these changes

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pxp928 @mihaimaruseac @lumjjb