Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added non-nil dereferencing to SLSA parser #1127

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Added non-nil dereferencing to SLSA parser #1127

merged 1 commit into from
Aug 9, 2023

Conversation

nathannaveen
Copy link
Contributor

@nathannaveen nathannaveen commented Aug 4, 2023 •
edited
Loading

Description of the PR

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@nathannaveen
Added non-nil dereferencing to SLSA parser
260c7a1 
* Added nil check to `stmt.Predicate.Metadata`
* Wrote tests for fillSLSA01
* fixes guacsec#1059
* Changed `inp.StartedOn = stmt.Predicate.Metadata.BuildStartedOn` to `inp.FinishedOn = stmt.Predicate.Metadata.BuildFinishedOn` on line 211.

Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
pxp928
pxp928 approved these changes Aug 4, 2023
View reviewed changes
Copy link
Collaborator

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @nathannaveen

@pxp928 pxp928 requested a review from lumjjb August 9, 2023 20:20
jeffmendoza
jeffmendoza approved these changes Aug 9, 2023
View reviewed changes
Copy link
Collaborator

@jeffmendoza jeffmendoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that bug on 211 =)

@kodiakhq kodiakhq bot merged commit 61f54cd into guacsec:main Aug 9, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffmendoza jeffmendoza jeffmendoza approved these changes

@pxp928 pxp928 pxp928 approved these changes

@lumjjb lumjjb Awaiting requested review from lumjjb

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ingestion/data-quality issue] SLSA parser should ensure fields are non-null before dereferencing
3 participants
@nathannaveen @jeffmendoza @pxp928