Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue where guac.yaml was not being read for backend configuration #2388

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

pxp928
Copy link
Collaborator

@pxp928 pxp928 commented Dec 19, 2024

Description of the PR

Introduced as part of PR: #2247, guac.yaml was not being properly read in for the backend configuration. This PR fixes this issues to allow for proper configuration set via guac.yaml.

FYI @robert-cronin

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If GraphQL schema is changed, GraphQL client updates/additions have been made
  • If OpenAPI spec is changed, make generate has been run
  • If ent schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@pxp928 pxp928 force-pushed the fix-guac-yaml-backends branch from 5e951bf to 3c9eb4b Compare December 19, 2024 14:49
@funnelfiasco
Copy link
Contributor

Is this something we could add tests for?

@pxp928
Copy link
Collaborator Author

pxp928 commented Dec 19, 2024

Is this something we could add tests for?

Hmm I am not sure if there is a good way to test this?

@mihaimaruseac
Copy link
Collaborator

We could add a test that looks at the running config, but it's hard to do and doesn't have much benefit, since we expect these to change very little

@pxp928 pxp928 requested a review from lumjjb December 19, 2024 15:21
@kodiakhq kodiakhq bot merged commit 73fa293 into main Dec 19, 2024
10 checks passed
@kodiakhq kodiakhq bot deleted the fix-guac-yaml-backends branch December 19, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants