Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eol to e2e and fix certifier logic #2396

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

robert-cronin
Copy link
Contributor

@robert-cronin robert-cronin commented Dec 20, 2024

Description of the PR

Fixes #2395

In addition to adding the e2e test query, this PR will also address some issues with the EOL certifier logic. For example, the parsing of purls now uses standard helper methods and the check for whether a node has EOL data is now more specific to mitigate false positives.

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If GraphQL schema is changed, GraphQL client updates/additions have been made
  • If OpenAPI spec is changed, make generate has been run
  • If ent schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@robert-cronin robert-cronin force-pushed the feat/add-eol-to-e2e branch 2 times, most recently from 6a26e15 to 958be3f Compare January 9, 2025 04:47
@robert-cronin
Copy link
Contributor Author

This PR should be merged after #2391

@robert-cronin robert-cronin marked this pull request as ready for review January 9, 2025 04:48
@robert-cronin
Copy link
Contributor Author

e2e test working locally:

@@@@ Running query EndOfLifeQ1
image

Signed-off-by: robert-cronin <robert.owen.cronin@gmail.com>
Signed-off-by: robert-cronin <robert.owen.cronin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Add EOL to e2e test
1 participant