chore: update rmcp v0.11.0 (TC-3269)#43
Merged
mrizzi merged 1 commit intoguacsec:mainfrom Dec 9, 2025
Merged
Conversation
Signed-off-by: mrizzi <mrizzi@redhat.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the rmcp dependency to v0.11.0 and removes SSE-specific binaries, features, and tests that are no longer supported by the SDK. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- With the removal of the
sseandserverbinaries, it’s likely that some dependencies (e.g.,axum, possibly others) are now unused; consider running a tool likecargo udepsto drop any no-longer-needed crates fromCargo.toml. - Since the
sseandserverbinaries are removed, double-check for any remaining references to these binaries in build scripts, CI configuration, or other project tooling to avoid broken commands.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- With the removal of the `sse` and `server` binaries, it’s likely that some dependencies (e.g., `axum`, possibly others) are now unused; consider running a tool like `cargo udeps` to drop any no-longer-needed crates from `Cargo.toml`.
- Since the `sse` and `server` binaries are removed, double-check for any remaining references to these binaries in build scripts, CI configuration, or other project tooling to avoid broken commands.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSE server removed from
rmcpin v0.11.0 through modelcontextprotocol/rust-sdk#562 hence removed from this MCP as well.Refer to https://issues.redhat.com/browse/TC-3269
Summary by Sourcery
Update rmcp dependency to v0.11.0 and remove SSE-based binaries and tests that are no longer supported.
Enhancements:
Build:
Tests: