Skip to content

chore: update rmcp v0.11.0 (TC-3269)#43

Merged
mrizzi merged 1 commit intoguacsec:mainfrom
mrizzi:chore-update-rmcp-v0.11.0
Dec 9, 2025
Merged

chore: update rmcp v0.11.0 (TC-3269)#43
mrizzi merged 1 commit intoguacsec:mainfrom
mrizzi:chore-update-rmcp-v0.11.0

Conversation

@mrizzi
Copy link
Contributor

@mrizzi mrizzi commented Dec 9, 2025

SSE server removed from rmcp in v0.11.0 through modelcontextprotocol/rust-sdk#562 hence removed from this MCP as well.
Refer to https://issues.redhat.com/browse/TC-3269

Summary by Sourcery

Update rmcp dependency to v0.11.0 and remove SSE-based binaries and tests that are no longer supported.

Enhancements:

  • Remove deprecated SSE and generic HTTP server binaries now unsupported by rmcp.

Build:

  • Bump rmcp runtime and dev-dependency versions from 0.10.0 to 0.11.0 and adjust enabled feature flags accordingly.

Tests:

  • Remove SSE-related integration tests that depended on the removed server binaries.

Signed-off-by: mrizzi <mrizzi@redhat.com>
@sourcery-ai
Copy link

sourcery-ai bot commented Dec 9, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the rmcp dependency to v0.11.0 and removes SSE-specific binaries, features, and tests that are no longer supported by the SDK.

File-Level Changes

Change Details Files
Remove SSE and HTTP server binaries and their associated integration tests now that rmcp no longer provides an SSE server.
  • Delete src/bin/sse.rs and src/bin/server.rs binaries from the project.
  • Remove [[bin]] declarations for the sse and server binaries from Cargo.toml.
  • Drop integration tests that exercised the SSE server and HTTP server endpoints in tests/integration_test.rs.
src/bin/sse.rs
src/bin/server.rs
Cargo.toml
tests/integration_test.rs
Upgrade rmcp runtime and dev-dependencies to v0.11.0 and align enabled feature flags with the new SDK capabilities.
  • Bump rmcp runtime dependency from 0.10.0 to 0.11.0 and remove the transport-sse-server feature flag.
  • Update rmcp dev-dependency from 0.10.0 to 0.11.0 keeping client and transport-child-process features.
  • Regenerate/adjust Cargo.lock to reflect the new rmcp version and transitive dependency graph.
Cargo.toml
Cargo.lock

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • With the removal of the sse and server binaries, it’s likely that some dependencies (e.g., axum, possibly others) are now unused; consider running a tool like cargo udeps to drop any no-longer-needed crates from Cargo.toml.
  • Since the sse and server binaries are removed, double-check for any remaining references to these binaries in build scripts, CI configuration, or other project tooling to avoid broken commands.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- With the removal of the `sse` and `server` binaries, it’s likely that some dependencies (e.g., `axum`, possibly others) are now unused; consider running a tool like `cargo udeps` to drop any no-longer-needed crates from `Cargo.toml`.
- Since the `sse` and `server` binaries are removed, double-check for any remaining references to these binaries in build scripts, CI configuration, or other project tooling to avoid broken commands.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@mrizzi mrizzi merged commit 8454af7 into guacsec:main Dec 9, 2025
2 checks passed
@mrizzi mrizzi deleted the chore-update-rmcp-v0.11.0 branch December 9, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant