Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Current combine code accepts only 30/60 images #222

Closed
sergiopasra opened this issue Oct 22, 2024 · 2 comments
Closed

Current combine code accepts only 30/60 images #222

sergiopasra opened this issue Oct 22, 2024 · 2 comments
Assignees
@sergiopasra
Labels
bug
Milestone
Numina v0.35.x

Comments

@sergiopasra
Copy link
Member

Due to the migration to numpy 2 (#219), the combine function has been reimplemented using NpyIter_MultiNew, but this function has a predefined limit of arguments of NPY_MAXARGS, being 32 in numpy 1.x and 64 in numpy 2.x.

This is a regression of previous behavior, when we were combining ~ 100 images without problems.

See numpy/numpy#4398
@sergiopasra sergiopasra added this to the Numina v0.34.x milestone Oct 22, 2024
@sergiopasra sergiopasra self-assigned this Oct 22, 2024
@sergiopasra
Copy link
Member Author

@nicocardiel

@sergiopasra
Copy link
Member Author

Reported in numpy numpy/numpy#27624

sergiopasra added a commit to sergiopasra/numina that referenced this issue Nov 12, 2024
@sergiopasra
Use several NpyIter ptrs (fixes guaix-ucm#222)
083f3d7 
This is a workaround to the limitation in the number of arguments in numpy (64 or 32 depending on the version)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergiopasra sergiopasra

Labels
bug
Projects
None yet
Milestone
Numina v0.35.x
Development

No branches or pull requests
1 participant
@sergiopasra