Fix linking issue due to missing inline keywords (#15)

* Add missing inline keywords * Bump version * Add version number to appveyor
guangie88 · Mar 24, 2018 · b18c857 · b18c857
1 parent e08cdd6
commit b18c857
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 10 deletions.
diff --git a/appveyor.yml b/appveyor.yml
@@ -1,3 +1,5 @@
+version: 0.3.0-alpha.1.{build}
+
 image:
   - Visual Studio 2015
   - Visual Studio 2017

diff --git a/include/spdlog_setup/conf.h b/include/spdlog_setup/conf.h
@@ -1,7 +1,7 @@
 /**
  * Implementation of public facing functions in spdlog_setup.
  * @author Chen Weiguang
- * @version 0.3.0-alpha.0
+ * @version 0.3.0-alpha.1
  */
 
 #pragma once
@@ -219,10 +219,10 @@ inline void save_logger_to_file(
 
     using details::find_item_by_name;
     using details::level_to_str;
-    using details::write_to_config_file;
     using details::names::LEVEL;
     using details::names::LOGGER_TABLE;
     using details::names::NAME;
+    using details::write_to_config_file;
 
     // fmt
     using fmt::format;
@@ -297,10 +297,10 @@ inline auto delete_logger_in_file(
 
     using details::find_item_iter_by_name;
     using details::level_to_str;
-    using details::write_to_config_file;
     using details::names::LEVEL;
     using details::names::LOGGER_TABLE;
     using details::names::NAME;
+    using details::write_to_config_file;
 
     // fmt
     using fmt::format;

diff --git a/include/spdlog_setup/details/conf_impl.h b/include/spdlog_setup/details/conf_impl.h
@@ -1,7 +1,7 @@
 /**
  * Implementation of non-public facing functions in spdlog_setup.
  * @author Chen Weiguang
- * @version 0.3.0-alpha.0
+ * @version 0.3.0-alpha.1
  */
 
 #pragma once
@@ -480,11 +480,11 @@ inline auto parse_max_size(const std::string &max_size_str) -> uint64_t {
     // std
     using std::exception;
     using std::regex;
+    using std::regex_constants::icase;
     using std::regex_match;
     using std::smatch;
     using std::stoull;
     using std::string;
-    using std::regex_constants::icase;
 
     try {
         static const regex RE(

diff --git a/include/spdlog_setup/details/setup_error.h b/include/spdlog_setup/details/setup_error.h
@@ -1,7 +1,7 @@
 /**
  * Implementation of setup_error in spdlog_setup.
  * @author Chen Weiguang
- * @version 0.3.0-alpha.0
+ * @version 0.3.0-alpha.1
  */
 
 #pragma once
@@ -44,10 +44,12 @@ class setup_error : public std::exception {
 
 // implementation section
 
-setup_error::setup_error(const char *const msg) : msg(msg) {}
+inline setup_error::setup_error(const char *const msg) : msg(msg) {}
 
-setup_error::setup_error(std::string msg) : msg(std::move(msg)) {}
+inline setup_error::setup_error(std::string msg) : msg(std::move(msg)) {}
 
-auto setup_error::what() const noexcept -> const char * { return msg.c_str(); }
+inline auto setup_error::what() const noexcept -> const char * {
+    return msg.c_str();
+}
 } // namespace details
 } // namespace spdlog_setup
diff --git a/src/unit_test/unit_test.cpp b/src/unit_test/unit_test.cpp
@@ -1,7 +1,7 @@
 /**
  * Unit tests implementation.
  * @author Chen Weiguang
- * @version 0.3.0-alpha.0
+ * @version 0.3.0-alpha.1
  */
 
 #define CATCH_CONFIG_MAIN