-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When watching several directories, only the last is actually watched. #243
Comments
Ruby version: |
@e2 any ideas about that one? https://twitter.com/chriseppstein/status/491276956084621312 |
Works in Linux, so it looks like an issue with darwin/FSEvent adapter (I don't have a Mac to properly test or debug on). What changed - I needed for each watched directory to have a separate callback (to unify and simplify Listen's adapters). (see https://github.com/guard/listen/blob/master/lib/listen/adapter/darwin.rb) @thibaudgg - could you confirm I'm using rb-fsevent the right way (i.e. calling |
@e2 calling multiple time |
@thibaudgg - I need one callback per directory (to later match the original watched directory based on the callback), so the fix is to have multiple FSEvent objects I guess. Could you review: #257 ? Ideally I'd add acceptance specs for this (mocking in adapter specs wouldn't make much sense), but looks like way too much work for now - acceptance specs and fixtures currently assume everything happens in a single watched directory. |
This is still broken after my "fix"- but now only the first directory is watched. |
Sorry for the delay, folks, but I had to rework how threads are used and finally add some specs to avoid breaking this every again. |
Listen version: 2.7.9
The callback only fires when filesystem events occur on the last directory specified.
The text was updated successfully, but these errors were encountered: