Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Ruby 1.8 support #96

Merged
merged 4 commits into from
Apr 10, 2013
Merged

Remove Ruby 1.8 support #96

merged 4 commits into from
Apr 10, 2013

Conversation

thibaudgg
Copy link
Member

@guard/core-team are you ready? :)

I think to release that in Listen 1.0.0 with adapters dependencies in gemspec. Sounds good to you?

@coveralls
Copy link

Changes Unknown when pulling 4583a83 on 19only into * on master*.

View Details

@rymai
Copy link
Member

rymai commented Apr 9, 2013

Awesome, I'm ready! Should we release 1.0 then? :)

What about #86 in that case? Should we implement the new start and start! before 1.0 (since it won't be backward-compatible)?

@thibaudgg
Copy link
Member Author

Yeah you right we also need to do #86 before 1.0.0, I forgot to mention it? Do you want to handle it? I will take care of #81.

thibaudgg added a commit that referenced this pull request Apr 10, 2013
@thibaudgg thibaudgg merged commit 2d4dc8b into master Apr 10, 2013
@thibaudgg thibaudgg deleted the 19only branch April 10, 2013 06:18
@netzpirat
Copy link
Contributor

❤️

@rymai
Copy link
Member

rymai commented Apr 10, 2013

@thibaudgg No you didn't forget to mention it, it's just that I thought that we would do a 1_0 branch, but using master is ok actually!

@rymai
Copy link
Member

rymai commented Apr 10, 2013

And yes I'd be glad to implement #86!

@thibaudgg
Copy link
Member Author

Nice, thanks!

@chriseppstein
Copy link

The default installed version on Macs is 1.8.7. So this patch makes it impossible to support standard ruby installs for projects that don't want to force users to install their own ruby. Compass uses listen and now we are left holding a giant bag of WTFs from our users who barely know what ruby is and are certainly not capable or willing to install it themselves.

Please revert this change.

@rymai
Copy link
Member

rymai commented Apr 29, 2013

The milestone was wrong, this will be done in 2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants