Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add buyer data to analytics where it's available #81

Merged
merged 3 commits into from
Feb 25, 2019

Conversation

kelvin-chappell
Copy link
Member

This expects bid responses to have buyer data in the format specified in prebid#3115 if there is any buyer data in the response.

The first bidder we integrated, Pubmatic, was done before a standard emerged. So the fields read are different. That means there will need to be a transition from the old fields to the new ones:

  1. Where the field is changing, read from both giving preference to the new field.
  2. Update the pubmatic bid response to use the new field.
  3. Update the analytics adapter to use only the new field.

Assuming that bid response has buyer data in format specified in
prebid#3115
@kelvin-chappell kelvin-chappell requested a review from a team as a code owner February 15, 2019 15:24
@kelvin-chappell kelvin-chappell merged commit b0244f6 into master Feb 25, 2019
@kelvin-chappell kelvin-chappell deleted the kc-buyer-data branch February 25, 2019 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant