Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uploading to S3 can fail #33

Closed
georgeblahblah opened this issue Apr 28, 2023 · 0 comments · Fixed by #60
Closed

Uploading to S3 can fail #33

georgeblahblah opened this issue Apr 28, 2023 · 0 comments · Fixed by #60

Comments

@georgeblahblah
Copy link
Contributor

georgeblahblah commented Apr 28, 2023 •
edited
Loading

Description

During migration of the frontend build from TeamCity to GitHub Actions, some uploads of the artifacts failed with the error:
/home/runner/runners/2.303.0/externals/node16/bin/node[6396]: ../src/node_http_parser.cc:517:static void node::{anonymous}::Parser::Execute(const v8::FunctionCallbackInfo<v8::Value>&): Assertion `parser->current_buffer_.IsEmpty()' failed..

What triggers the error isn't clear to me. Some light digging shows that the underlying cause may be resolved in Node 18. See aws/aws-sdk-js-v3#2843 for more details.

When Node 18 or higher is available to actions runners, we could investigate whether the issue is resolved.
@georgeblahblah georgeblahblah mentioned this issue Apr 28, 2023
Merged
17 tasks
@georgeblahblah georgeblahblah mentioned this issue May 22, 2023
Closed
georgeblahblah added a commit that referenced this issue Jul 21, 2023
@georgeblahblah
Convert to a composite action
67d50e2 
JavaScript actions have no way of supporting Node 18. We want to use
Node 18 to fix #33.

It seems that GitHub will never support `node18` for `actions/runner`,
instead jumping straight to Node 20.
georgeblahblah added a commit that referenced this issue Jul 26, 2023
@georgeblahblah
Convert to a composite action
04341c4 
JavaScript actions have no way of supporting Node 18. We want to use
Node 18 to fix #33.

It seems that GitHub will never support `node18` for `actions/runner`,
instead jumping straight to Node 20.
@georgeblahblah georgeblahblah mentioned this issue Jul 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Run action with Node 18 guardian/actions-riff-raff
1 participant
@georgeblahblah