Set node version explicitly instead of looking up .nvmrc
#61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxdvl
reviewed
Jul 26, 2023
Co-authored-by: Max Duval <max.duval@theguardian.com>
georgeblahblah
force-pushed
the
gb/set-node-version
branch
from
32bb6b0
to
d8bf833
Compare
Merged
|
There's some disconnect with this PR and the latest commit on the branch, d8bf833. Maybe it's better to use a specific node version instead of |
|
@georgeblahblah yep this branch is currently failing at guardian/devx-logs#28. So I'd be keen to hardcode the version and release so that we fix things at least - as there are a lot of repos using this, so it is likely there are others impacted beyond the initial report. |
nicl
approved these changes
Jul 26, 2023
There was a problem hiding this comment.
Have tested the latest version of this branch successfully here: guardian/devx-logs#28.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some projects using the action might not have an
.nvmrcfile, which causes the action to fail. This change sets a node version of "18.17.0" explicitly, instead of reading an.nvmrcfile.Thanks @coldlink for flagging